Conversation
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 19 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if ! gh api graphql -f query='mutation($discussionId: ID!, $body: String!) { addDiscussionComment(input: {discussionId: $discussionId, body: $body}) { comment { id } } }' -f discussionId="$DISCUSSION_ID" -f body="$CLOSE_MESSAGE"; then | ||
| echo " Error: Failed to add close comment for discussion #$DISCUSSION_NUMBER. Skipping close/lock for this discussion." | ||
| echo "" | ||
| continue | ||
| fi |
There was a problem hiding this comment.
When the close comment fails, the script continues to the next discussion without attempting to close or lock it, which is correct. However, if the comment was partially created (e.g., API accepted the request but the response was lost), subsequent runs might still try to close the discussion since no warning marker was added. This is acceptable behavior, but consider logging the discussion ID/number to a separate file for manual review in case of repeated failures.
|
@Tapanito I reduced the threshold from 1000 to 900 so it would trigger: https://github.com/XRPLF/XRPL-Standards/actions/runs/21291035207/job/61284406705?pr=426 |
This PR adds a bot that manages discussions in this repo. It comments in a discussion when it is old and closes and locks it if nobody responds.
Example: #97 (comment)
