make template checker script more robust#438
Merged
mvadari merged 4 commits intoXRPLF:masterfrom Jan 29, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request improves the robustness of the XLS template validation script by making it aware of existing ledger entries and transactions. Instead of requiring all subsections for all ledger entries and transactions, the script now dynamically checks if a ledger entry or transaction already exists on xrpl.org (by making HEAD requests to the documentation URLs) and exempts certain subsections from being required if they already exist on mainnet.
Changes:
- Added dynamic detection of existing ledger entries and transactions via HTTP requests to xrpl.org
- Updated template to annotate optional subsections for existing ledger entries (Ownership, Reserves, Deletion, RPC Name) and transactions (Transaction Fee)
- Added exemption logic in validator to skip required subsection checks for these optional sections when dealing with existing entries/transactions
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| templates/AMENDMENT_TEMPLATE.md | Added explanatory notes and "Optional" annotations to subsections that don't need to be included when documenting changes to existing ledger entries (2.4, 2.5, 2.6, 2.10) and transactions (3.3) |
| scripts/validate_xls_template.py | Added HTTP-based detection of existing ledger entries/transactions on xrpl.org and exemption logic to make certain subsections optional for existing types |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Tapanito
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RPC Name)