Skip to content

adds missing behavour to VaultSet transaction #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tapanito wants to merge 2 commits into
base: master
Choose a base branch
from
Open

adds missing behavour to VaultSet transaction #448

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85a956f
adds missing behavour to VaultSet transaction
Tapanito Feb 4, 2026
b0790ff
Merge branch 'master' into tapanito/sav-vault-set
mvadari Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion XLS-0065-single-asset-vault/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,7 +465,10 @@ The `VaultSet` updates an existing `Vault` ledger object.

- Update mutable fields in the `Vault` ledger object.
- If `DomainID` is provided:
- Set `MPTokenIssuance(Vault.ShareMPTID).DomainID = DomainID` (Set the Permissioned Domain).
- If `DomainID` is zero:
Copy link
Collaborator

@mvadari mvadari Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think this could be a touch clearer

Suggested change
- If `DomainID` is zero:
- If `DomainID` is zero (`000....000`):

- Clear `MPTokenIssuance(Vault.ShareMPTID).DomainID`
- Otherwise:
- Set `MPTokenIssuance(Vault.ShareMPTID).DomainID = DomainID` (Set the Permissioned Domain).

##### 3.1.2.3 Invariants

Expand Down
Loading