Skip to content

feat: server_definitions Formats, Fields, and Flags#464

Merged
mvadari merged 25 commits intoXRPLF:masterfrom
ckeshava:server_defs
Feb 27, 2026
Merged

feat: server_definitions Formats, Fields, and Flags#464
mvadari merged 25 commits intoXRPLF:masterfrom
ckeshava:server_defs

Conversation

@ckeshava
Copy link
Contributor

High Level Overview of Change

This PR adds the XLS specificaton document for enhancements to the server_definitions RPC. The content of this document is borrowed from #418 with a few modifications.

Section 3.2.1 has modificatons, as compared with the Discussion document.

Type of Change

  • New XLS Draft
  • XLS Update (changes to an existing XLS)
  • XLS Status Change (e.g., Draft → Final, Draft → Stagnant)
  • Process/Meta (changes to CONTRIBUTING.md, XLS-1, templates, etc.)
  • Infrastructure (CI, workflows, scripts, website)
  • Documentation (README updates, typo fixes)

Copy link
Collaborator

@mvadari mvadari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the process outlined in CONTRIBUTING.md.
Please also make the PR name more descriptive to this particular PR.

@github-actions
Copy link

github-actions bot commented Feb 13, 2026

🎫 XLS Number Assignment

This PR adds a new XLS draft. The next available XLS number has been determined:

Draft Directory Assigned Number New Directory Name
XLS-draft-server-definitions-enhancements XLS-97 xls-0097-server-definitions-enhancements

Next Steps for XLS Editors

Before merging this PR, please:

  1. Rename the directory from XLS-draft-server-definitions-enhancements to xls-0097-server-definitions-enhancements
  2. Update the preamble in the README.md:
    • Set xls: to 97
    • Set status: to Draft

This comment was automatically generated. The XLS number is based on the highest existing number in the repository at the time this PR was opened.

@ckeshava ckeshava changed the title feat: Add the XLS specification borrowed from Discussion feat: XLS-draft-server-definitions-enahancements Feb 13, 2026
@mvadari mvadari changed the title feat: XLS-draft-server-definitions-enahancements feat: server_definitions Formats, Fields, and Flags Feb 13, 2026
Copy link

@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to update the example output file 👍

@mvadari
Copy link
Collaborator

mvadari commented Feb 24, 2026

@ckeshava bump

ckeshava and others added 3 commits February 26, 2026 14:11
Co-authored-by: Mayukha Vadari <mvadari@gmail.com>
Co-authored-by: Mayukha Vadari <mvadari@gmail.com>
Co-authored-by: Mayukha Vadari <mvadari@gmail.com>
@ckeshava ckeshava requested a review from mvadari February 26, 2026 22:24
Copy link
Collaborator

@mvadari mvadari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, want @godexsoft to approve and the linter needs to be fixed before I'll approve

Copy link

@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mvadari
Copy link
Collaborator

mvadari commented Feb 27, 2026

@ckeshava please resolve all comments

@mvadari mvadari merged commit e5d2da9 into XRPLF:master Feb 27, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants