feat: server_definitions Formats, Fields, and Flags#464
Merged
mvadari merged 25 commits intoXRPLF:masterfrom Feb 27, 2026
Merged
feat: server_definitions Formats, Fields, and Flags#464mvadari merged 25 commits intoXRPLF:masterfrom
mvadari merged 25 commits intoXRPLF:masterfrom
Conversation
mvadari
requested changes
Feb 11, 2026
Collaborator
mvadari
left a comment
There was a problem hiding this comment.
Please follow the process outlined in CONTRIBUTING.md.
Please also make the PR name more descriptive to this particular PR.
🎫 XLS Number AssignmentThis PR adds a new XLS draft. The next available XLS number has been determined:
Next Steps for XLS EditorsBefore merging this PR, please:
This comment was automatically generated. The XLS number is based on the highest existing number in the repository at the time this PR was opened. |
mvadari
reviewed
Feb 13, 2026
mvadari
reviewed
Feb 13, 2026
mvadari
reviewed
Feb 13, 2026
mvadari
reviewed
Feb 13, 2026
mvadari
reviewed
Feb 13, 2026
Co-authored-by: Mayukha Vadari <mvadari@gmail.com>
godexsoft
suggested changes
Feb 16, 2026
godexsoft
left a comment
There was a problem hiding this comment.
Would be nice to update the example output file 👍
mvadari
reviewed
Feb 19, 2026
mvadari
reviewed
Feb 19, 2026
Collaborator
|
@ckeshava bump |
mvadari
reviewed
Feb 26, 2026
Co-authored-by: Mayukha Vadari <mvadari@gmail.com>
Co-authored-by: Mayukha Vadari <mvadari@gmail.com>
mvadari
reviewed
Feb 26, 2026
mvadari
reviewed
Feb 26, 2026
mvadari
reviewed
Feb 26, 2026
mvadari
reviewed
Feb 26, 2026
Co-authored-by: Mayukha Vadari <mvadari@gmail.com>
Co-authored-by: Mayukha Vadari <mvadari@gmail.com>
Co-authored-by: Mayukha Vadari <mvadari@gmail.com>
mvadari
reviewed
Feb 26, 2026
mvadari
reviewed
Feb 26, 2026
mvadari
reviewed
Feb 26, 2026
Co-authored-by: Mayukha Vadari <mvadari@gmail.com>
mvadari
reviewed
Feb 27, 2026
Collaborator
mvadari
left a comment
There was a problem hiding this comment.
LGTM, want @godexsoft to approve and the linter needs to be fixed before I'll approve
mvadari
approved these changes
Feb 27, 2026
Collaborator
|
@ckeshava please resolve all comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR adds the XLS specificaton document for enhancements to the server_definitions RPC. The content of this document is borrowed from #418 with a few modifications.
Section 3.2.1 has modificatons, as compared with the Discussion document.
Type of Change