Open
Conversation
sappenin
reviewed
Feb 26, 2026
Collaborator
sappenin
left a comment
sappenin
left a comment
There was a problem hiding this comment.
Overall LGTM, just a few comments (but they might not exactly align with XLS-0001, so take them or leave them).
| This document describes a proposal for supporting multiple signer lists per account. The current system of global signer lists will continue to be supported, but we propose adding **per-transaction-type signer lists**. Accounts can set up signer lists that only have the power to send **transactions of one specific type** on behalf of the account. | ||
|
|
||
| This proposal is related to [XLS-31](https://github.com/XRPLF/XRPL-Standards/discussions/77), but broader in scope. | ||
| ## 2. Motivation |
Collaborator
There was a problem hiding this comment.
This section feels like it's mostly repeating what's in the abstract. I like a good Motivation section in specs though, so maybe consider removing some of the redundancy from the Abstract?
| ``` | ||
|
|
||
| ### 3.1. Fields | ||
| ## 6. Rationale |
Collaborator
There was a problem hiding this comment.
Consider renaming this section to be Design Rational to better distinguish this section from the Motivation section above?
I also prefer an FAQ-style section (with that as the section name) over this kind of section, so the reader can properly frame any rationalization.
sappenin
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR update XLS-49 and XLS-74 to follow the latest format and remove mentions of XLS-49 from XLS-74.
Context of Change
updates
Type of Change