Skip to content

fix assign bot to not always return 96#478

Merged
mvadari merged 2 commits intomasterfrom
fix-assign-bot
Feb 24, 2026
Merged

fix assign bot to not always return 96#478
mvadari merged 2 commits intomasterfrom
fix-assign-bot

Conversation

@mvadari
Copy link
Collaborator

@mvadari mvadari commented Feb 23, 2026

High Level Overview of Change

This PR fixes an issue in the XLS assign bot where it wasn't looking at the right folder/repo.

Context of Change

The XLS assign bot is a bit broken - it returned 96 in #477 when it should have returned 97

Type of Change

  • Infrastructure (CI, workflows, scripts, website)

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the XLS number assignment automation so it calculates the next XLS number from the PR’s repository contents (instead of the sparse-checked-out base-branch script folder), addressing cases where it previously always returned 96.

Changes:

  • Pass the PR workspace root into the assignment step via REPO_ROOT.
  • Update assign_xls_number.py to prefer REPO_ROOT (with a fallback to deriving the path from the script location).
  • Add additional env vars to the workflow step (not all appear to be used).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/assign-xls-number.yml Exports REPO_ROOT (and other env vars) for the assignment step so the script can scan the correct checkout.
.github/scripts/assign_xls_number.py Uses REPO_ROOT env var to determine the repository root when computing the next available XLS number.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mvadari mvadari merged commit 67ee21d into master Feb 24, 2026
4 checks passed
@mvadari mvadari deleted the fix-assign-bot branch February 24, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants