Skip to content

Add mold linker to build images#49

Merged
Bronek merged 4 commits intomainfrom
add_mold_linker
Sep 24, 2025
Merged

Add mold linker to build images#49
Bronek merged 4 commits intomainfrom
add_mold_linker

Conversation

@Bronek
Copy link
Collaborator

@Bronek Bronek commented Sep 24, 2025

This change adds https://github.com/rui314/mold/ to build images. It will help us to build rippled faster.

Copy link
Collaborator

@mathbunnyru mathbunnyru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor change

@Bronek Bronek requested a review from mathbunnyru September 24, 2025 12:47
@mathbunnyru
Copy link
Collaborator

You're lucky the binary provided by the mold project, works across all OS and you don't need to build it :)

@Bronek Bronek merged commit 5dd7158 into main Sep 24, 2025
67 of 92 checks passed
@Bronek Bronek deleted the add_mold_linker branch September 24, 2025 13:43
@Bronek
Copy link
Collaborator Author

Bronek commented Sep 24, 2025

You're lucky the binary provided by the mold project, works across all OS and you don't need to build it :)

Indeed 😄

@lmaisons
Copy link

lmaisons commented Sep 24, 2025

What are the more esoteric implications of using mold over others? Stuff like cache alignment, link-time optimization, etc? It wasn't obvious from the project's README what they supported beyond providing the fastest link time.

EDIT:
At the very least it defaults to -z,relro,-z,now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants