Skip to content

feat: Use CMake 4.1.0 in all images#63

Merged
mathbunnyru merged 4 commits intomainfrom
cmake4
Oct 9, 2025
Merged

feat: Use CMake 4.1.0 in all images#63
mathbunnyru merged 4 commits intomainfrom
cmake4

Conversation

@mathbunnyru
Copy link
Collaborator

No description provided.

@mathbunnyru mathbunnyru changed the title feat: Use CMake 4.1.2 in all images feat: Use CMake 4.1.0 in all images Oct 8, 2025
@Bronek
Copy link
Collaborator

Bronek commented Oct 8, 2025

That will break rippled build, because some of the dependencies required by this project are not compatible with CMake 4. We could add to all dockerfiles a workaround documented here https://github.com/XRPLF/rippled/blob/develop/BUILD.md#workaround-for-cmake-4 or just stick to CMake 3 until all dependencies are fixed.

@mathbunnyru
Copy link
Collaborator Author

That will break rippled build, because some of the dependencies required by this project are not compatible with CMake 4. We could add to all dockerfiles a workaround documented here XRPLF/rippled@develop/BUILD.md#workaround-for-cmake-4 or just stick to CMake 3 until all dependencies are fixed.

That's not true, because I actually fixed all the dependencies to be compatible with CMake 4 :)

XRPLF/rippled#5866

@Bronek
Copy link
Collaborator

Bronek commented Oct 8, 2025

That will break rippled build, because some of the dependencies required by this project are not compatible with CMake 4. We could add to all dockerfiles a workaround documented here XRPLF/rippled@develop/BUILD.md#workaround-for-cmake-4 or just stick to CMake 3 until all dependencies are fixed.

That's not true, because I actually fixed all the dependencies to be compatible with CMake 4 :)

XRPLF/rippled#5866

I don't see how that PR fixes the dependencies ....

@mathbunnyru
Copy link
Collaborator Author

That will break rippled build, because some of the dependencies required by this project are not compatible with CMake 4. We could add to all dockerfiles a workaround documented here XRPLF/rippled@develop/BUILD.md#workaround-for-cmake-4 or just stick to CMake 3 until all dependencies are fixed.

That's not true, because I actually fixed all the dependencies to be compatible with CMake 4 :)
XRPLF/rippled#5866

I don't see how that PR fixes the dependencies ....

I fixed them in the CCI:
conan-io/conan-center-index#27973
conan-io/conan-center-index#27963

@mathbunnyru
Copy link
Collaborator Author

And since I used lockfiles in the rippled, now we're using modern recipes, which contain cmake 4 support

In Clio (which builds most dependencies rippled uses), we've been using CMake 4 for a long time, and haven't seen any issues

Copy link
Contributor

@bthomee bthomee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Now that we're pinning images in the rippled repo, there's no risk in merging this.

@mathbunnyru mathbunnyru merged commit 6948666 into main Oct 9, 2025
61 checks passed
@mathbunnyru mathbunnyru deleted the cmake4 branch October 9, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants