Merged
Conversation
Contributor
Author
|
@Bronek I made some changes to the GCC combinations to build, based on offline conversations. However, @legleux is building the .rpm using What's the list of configs you recommend we build for RHEL 8, 9, and 10? |
legleux
reviewed
Oct 10, 2025
docker/rhel/Dockerfile
Outdated
Comment on lines
+7
to
+11
| FROM rockylinux/rockylinux:${RHEL_VERSION} AS rocky | ||
| RUN dnf -y install rpm-sign rpmdevtools | ||
|
|
||
| # ====================== BASE IMAGE ====================== | ||
| ARG RHEL_VERSION |
Collaborator
There was a problem hiding this comment.
I would strongly suggest adhering to our commitment, or abandon it.
Get it from the distro repo be it Rocky or RH... not both.
We should have the credentials, we can just login and install it.
Didn't realize this was an account tied to you.
docker run --rm -it registry.access.redhat.com/ubi8/ubi
...
[root@341a31b0de71 /]# subscription-manager register --username $u --password $pw
Registering to: subscription.rhsm.redhat.com:443/subscription
...
[root@341a31b0de71 /]# dnf list all | grep -E '(rpmdevtools|rpm-sign|gold)'
gcc-toolset-12-binutils-gold.x86_64 2.38-17.el8 rhel-8-for-x86_64-appstream-rpms
gcc-toolset-12-binutils-gold.x86_64 2.38-17.el8 ubi-8-appstream-rpms
gcc-toolset-13-binutils-gold.x86_64 2.40-21.el8 rhel-8-for-x86_64-appstream-rpms
gcc-toolset-13-binutils-gold.x86_64 2.40-21.el8 ubi-8-appstream-rpms
gcc-toolset-14-binutils-gold.x86_64 2.41-4.el8_10 rhel-8-for-x86_64-appstream-rpms
gcc-toolset-14-binutils-gold.x86_64 2.41-4.el8_10 ubi-8-appstream-rpms
rpm-sign.x86_64 4.14.3-32.el8_10 rhel-8-for-x86_64-baseos-rpms
rpmdevtools.noarch 8.10-8.el8
Bronek
approved these changes
Oct 14, 2025
Contributor
Author
|
We can ignore the cleanup failure - it will succeed once the first RHEL 8 image gets pushed. |
legleux
reviewed
Oct 14, 2025
Bronek
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for RHEL 8, and makes related tweaks.
Specifically:
perl-File-Compare,perl-File-Copyandperl-FindBinpackages, even though this page says they are available from version RHEL 8.1 onward, and the latest UBI 8 image we're using contains RHEL 8.10. However, I manually created and pushed a Docker image without these packages and was able to build rippled with it. Thus the necessary packages appears to be already included in the base image, or OpenSSL 3.5.4 doesn't need them anymore or just not on RHEL 8.rpmdevtoolspackage, and none of the RHEL images haverpm-signthat we also need. Adding them requires registering via subscription-manager, which is a nuisance. Instead we will perform the signing in thetools-rippledimage for which we will create a separate PR.