Skip to content

feat: LPT freeze#1840

Merged
godexsoft merged 31 commits intoXRPLF:developfrom
shawnxie999:lpt-freeze
Feb 24, 2025
Merged

feat: LPT freeze#1840
godexsoft merged 31 commits intoXRPLF:developfrom
shawnxie999:lpt-freeze

Conversation

@shawnxie999
Copy link
Collaborator

@shawnxie999 shawnxie999 commented Jan 20, 2025

XRPLF/rippled#5227

Introduces amendment gating in accountHolds that so that the assets in the AMM are not frozen

@godexsoft godexsoft changed the title WIP lpt freeze feat: [WIP] LPT freeze Jan 21, 2025
@shawnxie999 shawnxie999 marked this pull request as ready for review January 23, 2025 21:55
@shawnxie999 shawnxie999 changed the title feat: [WIP] LPT freeze feat: LPT freeze Jan 27, 2025
@shawnxie999
Copy link
Collaborator Author

@godexsoft @cindyyan317 This PR is ready for review. There is still a test CI issue around SubscribeManager that needs to be resolved, but I don’t believe it should block the review process. However, I will have limited capacity to investigate this issue further over the next two weeks.

@codecov
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 82.02247% with 16 lines in your changes missing coverage. Please review.

Project coverage is 73.17%. Comparing base (427ba47) to head (c7f98fa).
Report is 14 commits behind head on develop.

Files with missing lines Patch % Lines
src/rpc/RPCHelpers.cpp 87.27% 3 Missing and 4 partials ⚠️
src/rpc/common/impl/HandlerProvider.cpp 0.00% 4 Missing ⚠️
src/app/ClioApplication.cpp 0.00% 2 Missing ⚠️
src/feed/SubscriptionManager.hpp 33.33% 2 Missing ⚠️
src/rpc/handlers/BookOffers.cpp 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1840      +/-   ##
===========================================
+ Coverage    72.71%   73.17%   +0.46%     
===========================================
  Files          333      337       +4     
  Lines        13525    13814     +289     
  Branches      6881     7004     +123     
===========================================
+ Hits          9835    10109     +274     
+ Misses        1785     1781       -4     
- Partials      1905     1924      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@cindyyan317 cindyyan317 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unittests for RPCHelper in RPCHelperTests.cpp.
For example:
when fixFrozenLPTokenTransfer enable/disable
when asset is frozen and asset2 is not
when asset is not and asset2 is frozen
when sfAMMID present/not present
...

cindyyan317
cindyyan317 previously approved these changes Feb 19, 2025
Copy link
Contributor

@cindyyan317 cindyyan317 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the comments.

Copy link
Collaborator

@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a few suggestions. Please note that these suggestions can be applied across all changes even though the comments are only for select lines

Copy link
Collaborator

@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@godexsoft godexsoft merged commit c9e8330 into XRPLF:develop Feb 24, 2025
21 checks passed
PeterChen13579 pushed a commit to PeterChen13579/clio that referenced this pull request Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants