Conversation
|
@godexsoft @cindyyan317 This PR is ready for review. There is still a test CI issue around |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1840 +/- ##
===========================================
+ Coverage 72.71% 73.17% +0.46%
===========================================
Files 333 337 +4
Lines 13525 13814 +289
Branches 6881 7004 +123
===========================================
+ Hits 9835 10109 +274
+ Misses 1785 1781 -4
- Partials 1905 1924 +19 ☔ View full report in Codecov by Sentry. |
cindyyan317
left a comment
There was a problem hiding this comment.
Please add unittests for RPCHelper in RPCHelperTests.cpp.
For example:
when fixFrozenLPTokenTransfer enable/disable
when asset is frozen and asset2 is not
when asset is not and asset2 is frozen
when sfAMMID present/not present
...
cindyyan317
left a comment
There was a problem hiding this comment.
Thanks for fixing the comments.
godexsoft
left a comment
There was a problem hiding this comment.
Adding a few suggestions. Please note that these suggestions can be applied across all changes even though the comments are only for select lines
XRPLF/rippled#5227
Introduces amendment gating in
accountHoldsthat so that the assets in the AMM are not frozen