Skip to content

feat: ETLng task manager#1843

Merged
godexsoft merged 13 commits intoXRPLF:developfrom
godexsoft:feature/etl-taskman-ng
Jan 29, 2025
Merged

feat: ETLng task manager#1843
godexsoft merged 13 commits intoXRPLF:developfrom
godexsoft:feature/etl-taskman-ng

Conversation

@godexsoft
Copy link
Collaborator

@godexsoft godexsoft commented Jan 21, 2025

Implementation of a task manager for ETL ng.
There are a couple TODOs left that require some changes in AsyncFramework to implement properly - I'd like to leave it for a separate PR and then fix those TODOs in a later stage of ETL ng implementation.

@codecov
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 84.52381% with 13 lines in your changes missing coverage. Please review.

Project coverage is 71.70%. Comparing base (3e200d8) to head (eebaf47).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/etlng/impl/TaskManager.cpp 78.84% 4 Missing and 7 partials ⚠️
src/util/StrandedPriorityQueue.hpp 90.47% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1843      +/-   ##
===========================================
+ Coverage    71.62%   71.70%   +0.08%     
===========================================
  Files          330      333       +3     
  Lines        13413    13488      +75     
  Branches      6826     6861      +35     
===========================================
+ Hits          9607     9672      +65     
  Misses        1921     1921              
- Partials      1885     1895      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@godexsoft godexsoft marked this pull request as ready for review January 27, 2025 14:53
cindyyan317
cindyyan317 previously approved these changes Jan 29, 2025
Copy link
Contributor

@cindyyan317 cindyyan317 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@godexsoft godexsoft merged commit 73f375f into XRPLF:develop Jan 29, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants