Skip to content

fix: gateway_balance discrepancy (#1839)#1874

Merged
kuznetsss merged 2 commits intoXRPLF:release/2.3.1from
kuznetsss:Port_gateway_balance_discrepancy
Feb 4, 2025
Merged

fix: gateway_balance discrepancy (#1839)#1874
kuznetsss merged 2 commits intoXRPLF:release/2.3.1from
kuznetsss:Port_gateway_balance_discrepancy

Conversation

@kuznetsss
Copy link
Collaborator

@codecov
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 71.94%. Comparing base (47c0a6a) to head (8a418bf).
Report is 3 commits behind head on release/2.3.1.

Files with missing lines Patch % Lines
src/rpc/handlers/GatewayBalances.hpp 50.00% 1 Missing and 9 partials ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           release/2.3.1    #1874      +/-   ##
=================================================
- Coverage          71.94%   71.94%   -0.01%     
=================================================
  Files                283      283              
  Lines              12067    12071       +4     
  Branches            6144     6146       +2     
=================================================
+ Hits                8682     8684       +2     
- Misses              1782     1784       +2     
  Partials            1603     1603              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kuznetsss kuznetsss requested a review from cindyyan317 February 4, 2025 15:13
cindyyan317
cindyyan317 previously approved these changes Feb 4, 2025
@kuznetsss kuznetsss force-pushed the Port_gateway_balance_discrepancy branch from 683432f to dc1b146 Compare February 4, 2025 16:36
Copy link
Collaborator

@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kuznetsss kuznetsss merged commit 3555b7d into XRPLF:release/2.3.1 Feb 4, 2025
16 checks passed
@kuznetsss kuznetsss deleted the Port_gateway_balance_discrepancy branch February 4, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants