fix: gateway_balance discrepancy (#1839)#1874
Merged
kuznetsss merged 2 commits intoXRPLF:release/2.3.1from Feb 4, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/2.3.1 #1874 +/- ##
=================================================
- Coverage 71.94% 71.94% -0.01%
=================================================
Files 283 283
Lines 12067 12071 +4
Branches 6144 6146 +2
=================================================
+ Hits 8682 8684 +2
- Misses 1782 1784 +2
Partials 1603 1603 ☔ View full report in Codecov by Sentry. |
cindyyan317
previously approved these changes
Feb 4, 2025
683432f to
dc1b146
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of #1839 into 2.3.1.
Fixes #1832.
rippled code:
https://github.com/XRPLF/rippled/blob/develop/src/xrpld/rpc/handlers/GatewayBalances.cpp#L129