chore: Pin external actions using hashes#2019
Merged
mathbunnyru merged 2 commits intoXRPLF:developfrom Apr 23, 2025
Merged
Conversation
kuznetsss
approved these changes
Apr 23, 2025
Collaborator
Author
|
The reason for this change - if someone whose lib we use decides to change their action in a malicious way, we will automatically start using it without even knowing something has changed. I don't pin github provided actions, because if they are compromised, we are probably done already, and it creates too much noise. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2019 +/- ##
===========================================
+ Coverage 72.71% 72.77% +0.05%
===========================================
Files 333 355 +22
Lines 13525 14669 +1144
Branches 6881 7448 +567
===========================================
+ Hits 9835 10675 +840
- Misses 1785 1972 +187
- Partials 1905 2022 +117 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: I used exactly the version which are already being used (didn't update anything).
Updates will come when we merge #2018