feat: Generate Debian packages with CPack

[legleux]

Builds the Linux packages with CPack.
Generate them by running Conan with --options:host "&:package=True" --options:host "&:static=True" then after the build you can run cpack . in the build directory.

@mathbunnyru Where do you think this should be built? QA needs a package per-commit.

@godexsoft What to do with the config.json and service file. I can just remove them or strip the comment out but it still won't work out the box with the default rippled.cfg. Relates to #2191.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.95%. Comparing base (c780ef8) to head (6fb8c13).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2282      +/-   ##
===========================================
+ Coverage    79.93%   79.95%   +0.01%     
===========================================
  Files          381      381              
  Lines        15762    15762              
  Branches      8254     8254              
===========================================
+ Hits         12600    12602       +2     
+ Misses        1892     1891       -1     
+ Partials      1270     1269       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[godexsoft]

@legleux imo we can drop the service file but let's keep the config. We can later adjust it to work with a default rippled (local) config if it does not already 👍

[mathbunnyru]

Is there any way to check this works in CI?
It would be nice to have a workflow

[mathbunnyru]

Where do you think this should be built? QA needs a package per-commit.

I don't mind having it here, if it's also tested here, that's why let's add a workflow

[legleux]

Is there any way to check this works in CI?

How do you test changes to CI nowadays?

Where do you think this should be built? QA needs a package per-commit.

I don't mind having it here, if it's also tested here, that's why let's add a workflow

I was thinking it should probably be part of build_and_test.yml since they want it for every commit and it needs the CMAKE_BINARY_DIR.

[mathbunnyru]

Is there any way to check this works in CI?

How do you test changes to CI nowadays?

Could you clarify your question, please?

Where do you think this should be built? QA needs a package per-commit.

I don't mind having it here, if it's also tested here, that's why let's add a workflow

I was thinking it should probably be part of build_and_test.yml since they want it for every commit and it needs the CMAKE_BINARY_DIR.

I think you can add it to build_impl.yml under a flag, and probably add the same flag to build_and_test.yml.
It won't be saved anywhere though.

[godexsoft]

@legleux imo we can drop the service file but let's keep the config. We can later adjust it to work with a default rippled (local) config if it does not already 👍

#2377 should set the config up to work with default rippled configuration

[godexsoft]

@legleux what remains for this to be merged?

[legleux]

@godexsoft When I had added the step to build the packages similar to the code_coverage step, I couldn't get to see the final outcome because the build kept failing (I'm pretty sure due to OOM on the runner).

[mathbunnyru]

Left some comments and question

I've also taken a look why the CI fails - you need to adjust build_impl.yml so it doesn't upload tests when it's package (and you might need to adjust clio_server upload as well)

[mathbunnyru]

I left some comments, mostly things I don't understand

[godexsoft]

Do we need to escape this as well?

[mathbunnyru]

Yes, fixed in #2469
Also, fixed some rename issues we had

@legleux just for the future, I think it is be better to rename variables separately as a refactor, to not miss places where rename is needed