chore: Remove all conan options and use purely CMake targets#2538
Merged
legleux merged 11 commits intoXRPLF:developfrom Sep 8, 2025
Merged
chore: Remove all conan options and use purely CMake targets#2538legleux merged 11 commits intoXRPLF:developfrom
legleux merged 11 commits intoXRPLF:developfrom
Conversation
mathbunnyru
force-pushed
the
no_conan_options
branch
from
f1ae608 to
d8a9e3f
Compare
godexsoft
reviewed
Sep 5, 2025
Collaborator
godexsoft
left a comment
godexsoft
left a comment
There was a problem hiding this comment.
I suggest to ask @maria-robobug to check the doc changes. Otherwise looks good 👍
Fixed formatting of the cmake command in the documentation.
Removed the loop that assigns options to CMake toolchain variables.
Collaborator
maria-robobug
left a comment
maria-robobug
left a comment
There was a problem hiding this comment.
Docs LGTM, just some minor comments.
Co-authored-by: Maria Shodunke <maria-robobug@users.noreply.github.com>
godexsoft
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #2535