fix: Remove RpcEntryNotFound from ClioError#2661
Merged
mathbunnyru merged 17 commits intoXRPLF:developfrom Feb 6, 2026
Merged
Conversation
mathbunnyru
reviewed
Nov 17, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2661 +/- ##
========================================
Coverage 82.02% 82.02%
========================================
Files 391 391
Lines 14636 14636
Branches 8007 8007
========================================
Hits 12005 12005
Misses 1449 1449
Partials 1182 1182 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mathbunnyru
previously approved these changes
Nov 18, 2025
Collaborator
|
Looks good, thanks! |
mathbunnyru
approved these changes
Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since rippled has its own error codes, all occurrences have been replaced except for PR2549, and the entry has also been removed entirely from Clio’s error enum. This modification follows the feedback provided in this comment: #2549 (comment)
Pending compatible libxrpl — temporarily on hold