Skip to content

fix: Address AmendmentBlockHandler flakiness in old ETL tests#2694

Merged
mathbunnyru merged 7 commits intoXRPLF:developfrom
godexsoft:bugfix/old-etl-notify-amendment-action
Oct 15, 2025
Merged

fix: Address AmendmentBlockHandler flakiness in old ETL tests#2694
mathbunnyru merged 7 commits intoXRPLF:developfrom
godexsoft:bugfix/old-etl-notify-amendment-action

Conversation

@godexsoft
Copy link
Collaborator

As the comment in the code suggests, this is merely a temporary workaround for a flaky test that will be removed in favour of ETLng.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Temporary workaround to stabilize a flaky AmendmentBlockHandler test by increasing the io_context runtime; intended to be removed with the old ETL deprecation in favor of ETLng.

  • Add explanatory comment about test flakiness and future removal.
  • Replace conditional run durations (1ms/10ms) with a fixed 50ms run to reduce flakiness.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.56%. Comparing base (b361e3a) to head (dbc998f).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2694   +/-   ##
========================================
  Coverage    79.56%   79.56%           
========================================
  Files          385      385           
  Lines        16153    16153           
  Branches      8459     8459           
========================================
  Hits         12852    12852           
  Misses        2012     2012           
  Partials      1289     1289           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mathbunnyru mathbunnyru merged commit b4e4055 into XRPLF:develop Oct 15, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants