fix: Address AmendmentBlockHandler flakiness in old ETL tests#2694
Merged
mathbunnyru merged 7 commits intoXRPLF:developfrom Oct 15, 2025
Merged
Conversation
…m:godexsoft/clio into bugfix/asan-fixes-notify-amendment-action
There was a problem hiding this comment.
Pull Request Overview
Temporary workaround to stabilize a flaky AmendmentBlockHandler test by increasing the io_context runtime; intended to be removed with the old ETL deprecation in favor of ETLng.
- Add explanatory comment about test flakiness and future removal.
- Replace conditional run durations (1ms/10ms) with a fixed 50ms run to reduce flakiness.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
kuznetsss
approved these changes
Oct 15, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2694 +/- ##
========================================
Coverage 79.56% 79.56%
========================================
Files 385 385
Lines 16153 16153
Branches 8459 8459
========================================
Hits 12852 12852
Misses 2012 2012
Partials 1289 1289 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mathbunnyru
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the comment in the code suggests, this is merely a temporary workaround for a flaky test that will be removed in favour of ETLng.