feat: Read and write LedgerCache to file#2761
Merged
kuznetsss merged 36 commits intoXRPLF:developfrom Nov 13, 2025
Merged
Conversation
kuznetsss
commented
Nov 7, 2025
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #2761 +/- ##
===========================================
+ Coverage 81.94% 82.01% +0.06%
===========================================
Files 372 378 +6
Lines 14009 14208 +199
Branches 7744 7843 +99
===========================================
+ Hits 11479 11652 +173
Misses 1438 1438
- Partials 1092 1118 +26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kuznetsss
force-pushed
the
2413_Read_write_cache_from_disk
branch
from
8123e9f to
c22fa4a
Compare
godexsoft
reviewed
Nov 11, 2025
Collaborator
godexsoft
left a comment
godexsoft
left a comment
There was a problem hiding this comment.
Left a few suggestions
mathbunnyru
requested changes
Nov 12, 2025
godexsoft
reviewed
Nov 13, 2025
mathbunnyru
approved these changes
Nov 13, 2025
| bool | ||
| InputFile::readRaw(char* data, size_t size) | ||
| { | ||
| file_.read(data, size); |
Contributor
There was a problem hiding this comment.
null check before reading?
Collaborator
Author
There was a problem hiding this comment.
It will crash anyway if nullptr is passed here. Or do you mean something else?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2413.