Skip to content

chore: Fix pre commit hook failing on empty file #2766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kuznetsss merged 1 commit into from
Nov 10, 2025
Merged

chore: Fix pre commit hook failing on empty file #2766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .clang-format
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ IndentFunctionDeclarationAfterType: false
IndentWidth: 4
IndentWrappedFunctionNames: false
IndentRequiresClause: true
InsertNewlineAtEOF: true
RequiresClausePosition: OwnLine
KeepEmptyLinesAtTheStartOfBlocks: false
MaxEmptyLinesToKeep: 1
Expand Down
11 changes: 10 additions & 1 deletion pre-commit-hooks/json_in_cpp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,13 @@ def replace_json(match):


def fix_indentation(cpp_content: str) -> str:
if "JSON(" not in cpp_content:
return cpp_content

lines = cpp_content.splitlines()

ends_with_newline = cpp_content.endswith('\n')

def find_indentation(line: str) -> int:
return len(line) - len(line.lstrip())

Expand All @@ -66,7 +71,11 @@ def find_indentation(line: str) -> int:
break
lines[i] = lines[i][by_how_much:] if by_how_much > 0 else " " * (-by_how_much) + lines[i]

return "\n".join(lines) + "\n"
result = "\n".join(lines)

if ends_with_newline:
result += "\n"
return result


def process_file(file_path: Path, dry_run: bool) -> bool:
Expand Down