Skip to content

chore: Enable TSAN without ignoring errors#2828

Merged
godexsoft merged 11 commits intoXRPLF:developfrom
godexsoft:chore/tsan-enable
Jan 30, 2026
Merged

chore: Enable TSAN without ignoring errors#2828
godexsoft merged 11 commits intoXRPLF:developfrom
godexsoft:chore/tsan-enable

Conversation

@godexsoft
Copy link
Collaborator

Let's wait for last TSAN issues to be fixed in @kuznetsss 's ongoing PR before merging this.
Another thing is that we may want to set up so that any warning/error from sanitizers immediately halts clio_tests.

@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.03%. Comparing base (cf77a10) to head (91012c9).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/feed/impl/TrackableSignal.hpp 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2828      +/-   ##
===========================================
- Coverage    82.06%   82.03%   -0.04%     
===========================================
  Files          391      391              
  Lines        14630    14636       +6     
  Branches      8005     8007       +2     
===========================================
  Hits         12006    12006              
- Misses        1442     1449       +7     
+ Partials      1182     1181       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@mathbunnyru mathbunnyru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be great if you commented on GitHub what was wrong with the initial code

@godexsoft
Copy link
Collaborator Author

I think it would be great if you commented on GitHub what was wrong with the initial code

It's in the comment above the code that had to change

@godexsoft godexsoft marked this pull request as ready for review January 30, 2026 15:25
@godexsoft godexsoft merged commit 9fd15eb into XRPLF:develop Jan 30, 2026
102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants