fix: Faster implementation of work queue#2887
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2887 +/- ##
========================================
Coverage 81.86% 81.87%
========================================
Files 382 382
Lines 14506 14490 -16
Branches 7960 7948 -12
========================================
- Hits 11876 11863 -13
Misses 1451 1451
+ Partials 1179 1176 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…nto bugfix/workqueue-faster
124 seconds for 1 test with codecov |
That's so painful.. but i don't see a better way to implement this test since AssertMock failed us 😢 Should we consider to disable the test until better times? perhaps it's not important enough to waste 124 seconds every CI run.. we know the ASSERT will work. |
It's WorkQueue's design, not AssertMock. We could disable this test and create an issue to fix it later. |
The new work queue implementation seems to be too slow because of its dispatcher component.
According to micro benchmark, this implementation appears to be nearly as fast as the original that did not support priorities.