Skip to content

refactor: Add etl system state command#2894

Closed
kuznetsss wants to merge 36 commits intoXRPLF:developfrom
kuznetsss:Add_etl_system_state_command
Closed

refactor: Add etl system state command#2894
kuznetsss wants to merge 36 commits intoXRPLF:developfrom
kuznetsss:Add_etl_system_state_command

Conversation

@kuznetsss
Copy link
Collaborator

@kuznetsss kuznetsss commented Jan 9, 2026

SystemState was using bool flags. This refactoring switches it to use signals making it easier to control writing state from outside of ETL.

@kuznetsss kuznetsss force-pushed the Add_etl_system_state_command branch from bd0ffce to 4599a70 Compare January 9, 2026 17:58
@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

❌ Patch coverage is 79.01786% with 47 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.97%. Comparing base (b983aea) to head (690e939).

Files with missing lines Patch % Lines
src/app/ClioApplication.cpp 0.00% 13 Missing ⚠️
src/etl/ETLService.cpp 67.74% 3 Missing and 7 partials ⚠️
src/etl/WriterState.cpp 75.00% 5 Missing ⚠️
src/cluster/Backend.cpp 91.48% 2 Missing and 2 partials ⚠️
src/cluster/WriterDecider.cpp 84.61% 2 Missing and 2 partials ⚠️
src/etl/SystemState.hpp 0.00% 4 Missing ⚠️
src/cluster/ClioNode.cpp 88.23% 0 Missing and 2 partials ⚠️
src/cluster/impl/RepeatedTask.hpp 90.90% 0 Missing and 2 partials ⚠️
src/util/async/context/impl/Execution.hpp 77.77% 0 Missing and 2 partials ⚠️
src/app/Stopper.hpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2894      +/-   ##
===========================================
+ Coverage    81.86%   81.97%   +0.11%     
===========================================
  Files          382      391       +9     
  Lines        14494    14595     +101     
  Branches      7951     7989      +38     
===========================================
+ Hits         11865    11964      +99     
+ Misses        1451     1448       -3     
- Partials      1178     1183       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small comments 👍

@kuznetsss kuznetsss requested a review from godexsoft January 14, 2026 15:20
@kuznetsss kuznetsss force-pushed the Add_etl_system_state_command branch 2 times, most recently from d3fe795 to 0737efc Compare January 15, 2026 16:12
@kuznetsss kuznetsss force-pushed the Add_etl_system_state_command branch from 690e939 to d4236b1 Compare January 16, 2026 11:59
@kuznetsss
Copy link
Collaborator Author

Closing in favour of #2830

@kuznetsss kuznetsss closed this Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants