Skip to content

fix: Workaround an edge case exception in AmendmentCenter#2897

Merged
godexsoft merged 6 commits intoXRPLF:developfrom
godexsoft:bugfix/workaround-amendmentcenter-exception
Jan 13, 2026
Merged

fix: Workaround an edge case exception in AmendmentCenter#2897
godexsoft merged 6 commits intoXRPLF:developfrom
godexsoft:bugfix/workaround-amendmentcenter-exception

Conversation

@godexsoft
Copy link
Collaborator

Fixes #2881

From my tests the output of account_info is now identical with xrpld.
I'd like to investigate this further in the future and possibly find a better fix if there is one in #2895

@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

❌ Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.86%. Comparing base (e733fad) to head (ce0e875).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/data/AmendmentCenter.cpp 63.63% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2897      +/-   ##
===========================================
- Coverage    81.86%   81.86%   -0.01%     
===========================================
  Files          382      382              
  Lines        14506    14510       +4     
  Branches      7960     7963       +3     
===========================================
+ Hits         11876    11878       +2     
  Misses        1451     1451              
- Partials      1179     1181       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@godexsoft godexsoft requested a review from mathbunnyru January 12, 2026 18:22
@godexsoft godexsoft merged commit f33f15c into XRPLF:develop Jan 13, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

account_info fails with internal error (73) for specific historical ledger on Clio

3 participants