Skip to content

ci: Pass version explicitly and don't rely on tags#2904

Merged
mathbunnyru merged 5 commits intoXRPLF:developfrom
mathbunnyru:explicit_version
Jan 12, 2026
Merged

ci: Pass version explicitly and don't rely on tags#2904
mathbunnyru merged 5 commits intoXRPLF:developfrom
mathbunnyru:explicit_version

Conversation

@mathbunnyru
Copy link
Collaborator

Relying on tags doesn't work when making nightly releases.
If we make a nightly release first time, version will be sth like develop-<date>-<short-rev>.
But if we don't commit for a while and nightly runs again, we will see previously created tag, and will use it.

This PR makes our build process not rely on tags, and purely rely on the type of event being triggered and passes this information to CMake explicitly.

@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.88%. Comparing base (bb39bce) to head (6fbad12).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2904      +/-   ##
===========================================
- Coverage    81.92%   81.88%   -0.05%     
===========================================
  Files          382      382              
  Lines        14504    14504              
  Branches      7960     7960              
===========================================
- Hits         11882    11876       -6     
- Misses        1442     1449       +7     
+ Partials      1180     1179       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:rage1:

@mathbunnyru mathbunnyru merged commit e733fad into XRPLF:develop Jan 12, 2026
112 of 113 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants