ci: Pass version explicitly and don't rely on tags#2904
Merged
mathbunnyru merged 5 commits intoXRPLF:developfrom Jan 12, 2026
Merged
ci: Pass version explicitly and don't rely on tags#2904mathbunnyru merged 5 commits intoXRPLF:developfrom
mathbunnyru merged 5 commits intoXRPLF:developfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2904 +/- ##
===========================================
- Coverage 81.92% 81.88% -0.05%
===========================================
Files 382 382
Lines 14504 14504
Branches 7960 7960
===========================================
- Hits 11882 11876 -6
- Misses 1442 1449 +7
+ Partials 1180 1179 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relying on tags doesn't work when making nightly releases.
If we make a nightly release first time, version will be sth like
develop-<date>-<short-rev>.But if we don't commit for a while and nightly runs again, we will see previously created tag, and will use it.
This PR makes our build process not rely on tags, and purely rely on the type of event being triggered and passes this information to CMake explicitly.