Skip to content

fix: No output from failed asserts in tests#2905

Merged
kuznetsss merged 2 commits intoXRPLF:developfrom
kuznetsss:Fix_silent_asserts_in_tests
Jan 12, 2026
Merged

fix: No output from failed asserts in tests#2905
kuznetsss merged 2 commits intoXRPLF:developfrom
kuznetsss:Fix_silent_asserts_in_tests

Conversation

@kuznetsss
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.86%. Comparing base (bb39bce) to head (5248592).
⚠️ Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
src/util/Assert.cpp 0.00% 2 Missing ⚠️
src/util/log/Logger.cpp 0.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (20.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2905      +/-   ##
===========================================
- Coverage    81.92%   81.86%   -0.06%     
===========================================
  Files          382      382              
  Lines        14504    14506       +2     
  Branches      7960     7960              
===========================================
- Hits         11882    11876       -6     
- Misses        1442     1451       +9     
+ Partials      1180     1179       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mathbunnyru
mathbunnyru previously approved these changes Jan 12, 2026
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
@kuznetsss kuznetsss merged commit 88866ea into XRPLF:develop Jan 12, 2026
27 of 28 checks passed
@kuznetsss kuznetsss deleted the Fix_silent_asserts_in_tests branch January 12, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants