Conversation
mathbunnyru
left a comment
There was a problem hiding this comment.
At the bottom of this file, instead of having if: ${{ github.ref_type == 'branch' && github.ref_name == github.event.repository.default_branch }} let's write it much simpler: if: ${{ github.event_name == 'push' }}
mathbunnyru
left a comment
There was a problem hiding this comment.
Please, see my comment above.
Also, please make it work for forks - you shouldn't login, so it should also be under if
Good call, done. |
Regarding forks... let me add the same logic here as we have in the rippled repo. |
The
on: pushdoes not always trigger on new commits pushed to a branch. This change adds a specificon: pull_request.