Skip to content

Fix 'on: push' branch and only log into Conan remote when pushing#22

Merged
mathbunnyru merged 4 commits intomasterfrom
bthomee/conan
Nov 20, 2025
Merged

Fix 'on: push' branch and only log into Conan remote when pushing#22
mathbunnyru merged 4 commits intomasterfrom
bthomee/conan

Conversation

@bthomee
Copy link

@bthomee bthomee commented Nov 20, 2025

  • The on: push used the main branch, but since this is a fork of the conan center index repo, we need to use the master branch instead.
  • To make it possible for forks of the rippled repo to pull recipes from the Conan registry, the remote name and URL were moved from org/repo variables into env vars. Here the same is done.
  • We now only add the remote and dry-run the upload in the XRPLF repo, and only log into the remote and do the upload when pushing.

@bthomee bthomee requested a review from mathbunnyru November 20, 2025 15:25
Copy link
Collaborator

@mathbunnyru mathbunnyru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove some ifs and also hash-pin actions

@mathbunnyru mathbunnyru merged commit 127143d into master Nov 20, 2025
1 check passed
@mathbunnyru mathbunnyru deleted the bthomee/conan branch November 20, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants