Conversation
b9bcaca to
1624f2b
Compare
|
@oleks-rip is the |
bthomee
left a comment
There was a problem hiding this comment.
You'll also need to update the export workflow:
conan export wasmi/all --version=1.0.4
Ye, there were some memory spikes in qa test, so we will continue to use 2 engines for some time to find differences. It will be removed before going to production
fixed |
Remove incompatible release
mathbunnyru
left a comment
There was a problem hiding this comment.
Please, do not merge this yet
I will discuss with Kenny this Thursday, how we will be maintaining recipes like this
mathbunnyru
left a comment
There was a problem hiding this comment.
Since we're using our own fork, maybe let's call the recipe wasmi-xrplf?
We did the same naming for the same reason for wasm-xrplf.
It would show that it's built from our xrplf org fork, and not from original sources.
|
Improved slightly the PR title |
wamr is present in conan-central so we renamed our, wasmi is not present and since they don't care match about C-API I doubt it will be. |
Makes sense, let's merge it now and keep it mind if cci adds official version |
Switch to v1.0.4 release