Skip to content

Update wasmi recipe to 1.0.6#27

Merged
mathbunnyru merged 6 commits intoXRPLF:masterfrom
oleks-rip:wasmi1
Jan 11, 2026
Merged

Update wasmi recipe to 1.0.6#27
mathbunnyru merged 6 commits intoXRPLF:masterfrom
oleks-rip:wasmi1

Conversation

@oleks-rip
Copy link

@oleks-rip oleks-rip commented Dec 8, 2025

Switch to v1.0.4 release

@oleks-rip oleks-rip force-pushed the wasmi1 branch 2 times, most recently from b9bcaca to 1624f2b Compare December 10, 2025 22:36
@bthomee bthomee requested a review from mathbunnyru December 12, 2025 15:42
@bthomee
Copy link

bthomee commented Dec 12, 2025

@oleks-rip is the wasm-xrplf recipe still needed? If not, can you please remove it in a separate PR (including from the export workflow)?

Copy link

@bthomee bthomee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also need to update the export workflow:

conan export wasmi/all --version=1.0.4

@oleks-rip
Copy link
Author

oleks-rip commented Dec 12, 2025

@oleks-rip is the wasm-xrplf recipe still needed? If not, can you please remove it in a separate PR (including from the export workflow)?

Ye, there were some memory spikes in qa test, so we will continue to use 2 engines for some time to find differences. It will be removed before going to production

conan export wasmi/all --version=1.0.4

fixed

Remove incompatible release
Copy link
Collaborator

@mathbunnyru mathbunnyru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, do not merge this yet

I will discuss with Kenny this Thursday, how we will be maintaining recipes like this

@oleks-rip oleks-rip marked this pull request as draft January 8, 2026 19:42
@oleks-rip oleks-rip marked this pull request as ready for review January 9, 2026 18:51
Copy link
Collaborator

@mathbunnyru mathbunnyru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're using our own fork, maybe let's call the recipe wasmi-xrplf?
We did the same naming for the same reason for wasm-xrplf.
It would show that it's built from our xrplf org fork, and not from original sources.

@mathbunnyru mathbunnyru requested a review from mvadari January 9, 2026 19:01
@mathbunnyru mathbunnyru changed the title wasmi v1 Update wasmi recipe to 1.0.6 Jan 9, 2026
@mathbunnyru
Copy link
Collaborator

Improved slightly the PR title

@oleks-rip
Copy link
Author

Since we're using our own fork, maybe let's call the recipe wasmi-xrplf? We did the same naming for the same reason for wasm-xrplf. It would show that it's built from our xrplf org fork, and not from original sources.

wamr is present in conan-central so we renamed our, wasmi is not present and since they don't care match about C-API I doubt it will be.

@mathbunnyru
Copy link
Collaborator

Since we're using our own fork, maybe let's call the recipe wasmi-xrplf? We did the same naming for the same reason for wasm-xrplf. It would show that it's built from our xrplf org fork, and not from original sources.

wamr is present in conan-central so we renamed our, wasmi is not present and since they don't care match about C-API I doubt it will be.

Makes sense, let's merge it now and keep it mind if cci adds official version

@mathbunnyru mathbunnyru requested review from Copilot and removed request for Copilot January 11, 2026 20:51
@mathbunnyru mathbunnyru merged commit 09b9a53 into XRPLF:master Jan 11, 2026
5 checks passed
@oleks-rip oleks-rip deleted the wasmi1 branch January 12, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants