Skip to content

Add options to disable ciphers#32

Merged
bthomee merged 6 commits intomasterfrom
bthomee/openssl
Jan 12, 2026
Merged

Add options to disable ciphers#32
bthomee merged 6 commits intomasterfrom
bthomee/openssl

Conversation

@bthomee
Copy link

@bthomee bthomee commented Jan 12, 2026

To have more granular control over the ciphers we support, this change supports selectively disabling DTLS and TLSv1.

Copy link
Collaborator

@lmaisons lmaisons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me given the constraints. I wish I had a better idea for what to do with the underscore / dash foot-gun between the Conan variables and what OpenSSL's Configure script expects.

@bthomee
Copy link
Author

bthomee commented Jan 12, 2026

Looks OK to me given the constraints. I wish I had a better idea for what to do with the underscore / dash foot-gun between the Conan variables and what OpenSSL's Configure script expects.

It's something that would require a larger refactor, and then proposing upstream too, to reduce future conflicts. Definitely something for a future PR, if at all.

@bthomee bthomee merged commit 5ea5303 into master Jan 12, 2026
1 check passed
@bthomee bthomee deleted the bthomee/openssl branch January 12, 2026 23:04
Copy link
Collaborator

@mathbunnyru mathbunnyru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bthomee I think security-related changes should always have 2 approvals, and everything openssl-related is definitely a security-related change.

This change introduces a bug, where some options won't be passed correctly to the openssl build configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants