Add a selection of private headers to the secp256k1 package#35
Merged
mathbunnyru merged 2 commits intomasterfrom Feb 4, 2026
Merged
Add a selection of private headers to the secp256k1 package#35mathbunnyru merged 2 commits intomasterfrom
mathbunnyru merged 2 commits intomasterfrom
Conversation
mathbunnyru
changed the title
bthomee
reviewed
Feb 4, 2026
| self, | ||
| header, | ||
| src=os.path.join(self.source_folder, "src"), | ||
| dst=os.path.join(self.package_folder, "include", "private") |
There was a problem hiding this comment.
Can these headers just be moved to another directory without breaking the compilation? I would've expected that the secp256k1 build would fail as #include "some_file.h" would now be in #include "private/some_file.h".
Collaborator
Author
There was a problem hiding this comment.
I tried it, unfortunately, it doesn't compile.
And I like this way better, because we don't change in any way how the binary is built.
There was a problem hiding this comment.
I meant to say: "does the way in which you do this, as presented in this PR, result in compilation failures?" but you now answered that question 🙂
bthomee
changed the title
bthomee
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/XRPLF/mpt-crypto library uses some private headers of secp256k1.
So, I copy them (and their dependencies) to
include/private.This allows conan to be used for secp256k1 library