Skip to content

Use XRPLF heavy runners #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Patel-Raj11 wants to merge 5 commits into
base: main
Choose a base branch
from
+15 −15
Open

Use XRPLF heavy runners #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8dba0c4
use heavy runners
Patel-Raj11 Apr 27, 2026
994fe57
add prepare runner step
Patel-Raj11 Apr 27, 2026
3fb52aa
use clio-ci container
Patel-Raj11 Apr 27, 2026
53ea983
use binfmt
Patel-Raj11 Apr 27, 2026
e292fcd
use Github runner for linux-s390x
Patel-Raj11 Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 14 additions & 15 deletions .github/workflows/build-shared-libs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
matrix:
include:
# ── macOS ARM64 (Apple Silicon) ──
- os: macos-14
- os: macos15
platform: darwin-aarch64
lib_filename: libmpt-crypto.dylib

Expand All @@ -62,14 +62,16 @@ jobs:
lib_filename: libmpt-crypto.dylib

# ── Linux ARM64 ──
- os: ubuntu-24.04-arm
- os: heavy-arm64
platform: linux-aarch64
lib_filename: libmpt-crypto.so
container: '{ "image": "ghcr.io/xrplf/clio-ci:14342e087ceb8b593027198bf9ef06a43833c696" }'
Comment thread
mathbunnyru marked this conversation as resolved.

# ── Linux x86_64 ──
- os: ubuntu-latest
- os: heavy
platform: linux-x86-64
lib_filename: libmpt-crypto.so
container: '{ "image": "ghcr.io/xrplf/clio-ci:14342e087ceb8b593027198bf9ef06a43833c696" }'

# ── Linux s390x (IBM Z) — built via QEMU user-mode emulation ──
- os: ubuntu-latest

@mathbunnyru mathbunnyru Apr 27, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can and should still use heavy here

@Patel-Raj11 Patel-Raj11 Apr 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mathbunnyru I tried using heavy runners for s390x, but it keeps failing with the error seen in below mentioned run. After some back and forth with Claude, it seems that heavy runners are running in some sandbox/VM/namespace such that docker/setup-qemu-action is not working as intended.

https://github.com/XRPLF/mpt-crypto/actions/runs/24976270406/job/73128730834

Can you see if you can suggest something based on the error message? Or s390x is quite unique (it needs docker emulation) so can we keep using GHA runners?

Expand All @@ -79,13 +81,18 @@ jobs:
docker_image: s390x/ubuntu:24.04

# ── Windows x86_64 ──
- os: windows-latest
- os: windows
platform: win32-x86-64
lib_filename: mpt-crypto.dll

runs-on: ${{ matrix.os }}
container: ${{ matrix.container != '' && fromJson(matrix.container) || null }}

steps:
- name: Cleanup workspace
if: matrix.os == 'macos15'
uses: XRPLF/actions/cleanup-workspace@c7d9ce5ebb03c752a354889ecd870cadfc2b1cd4

- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

- name: Set up QEMU
Expand All @@ -94,19 +101,11 @@ jobs:
with:
platforms: ${{ matrix.docker_platform }}

- name: Set up Python
- name: Prepare runner
if: matrix.docker_platform == ''
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
uses: XRPLF/actions/prepare-runner@2cbf481018d930656e9276fcc20dc0e3a0be5b6d
with:
python-version: "3.12"

- name: Install Conan and Ninja
if: matrix.docker_platform == ''
run: pip install conan ninja

- name: Set up MSVC environment
if: runner.os == 'Windows'
uses: ilammy/msvc-dev-cmd@a102174a2b586eec2ea151a69e6fd14404a8ce7c # v1.13.0
enable_ccache: false

- name: Build and test
if: matrix.docker_platform == ''
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ jobs:
# the reusable workflow.
native-binaries:
name: Build native shared libraries
if: github.repository_owner == 'XRPLF'
permissions:
contents: read
uses: ./.github/workflows/build-shared-libs.yml
Expand Down
Loading