feature: Single Asset Vault

[thejohnfreeman]

Starting a draft PR for incremental review.

Based on:

• MPT branch with variant STIssue
• Consolidate definitions of fields, objects, transactions, and features #5122
• Add a new serialized type: STNumber #5121

[donovanhide]

Is there an XLS document for this new feature? Thanks.

[Bronek]

Is there an XLS document for this new feature? Thanks.

Hi Donovan, please note this is a Draft, meaning the implementation here should be in no way considered complete or reflecting the actual product which will be subject to amendment voting. Having said that, this project started with the discussion at XRPLF/XRPL-Standards#190

[codecov]

Codecov Report

Attention: Patch coverage is 80.30513% with 284 lines in your changes missing coverage. Please review.

Project coverage is 76.2%. Comparing base (bf4a7b6) to head (eafaf76).

Files with missing lines	Patch %	Lines
src/libxrpl/protocol/STAmount.cpp	74.0%	45 Missing ⚠️
src/xrpld/rpc/handlers/LedgerEntry.cpp	5.9%	32 Missing ⚠️
src/xrpld/app/tx/detail/InvariantCheck.cpp	65.5%	30 Missing ⚠️
src/libxrpl/basics/MPTAmount.cpp	8.3%	22 Missing ⚠️
src/xrpld/app/tx/detail/Payment.cpp	85.4%	21 Missing ⚠️
src/xrpld/app/tx/detail/VaultSet.cpp	0.0%	19 Missing ⚠️
src/libxrpl/protocol/STIssue.cpp	52.9%	16 Missing ⚠️
src/xrpld/ledger/detail/View.cpp	91.7%	11 Missing ⚠️
src/libxrpl/protocol/Asset.cpp	72.4%	8 Missing ⚠️
src/libxrpl/protocol/STNumber.cpp	73.3%	8 Missing ⚠️
... and 22 more

Additional details and impacted files

@@            Coverage Diff            @@
##           develop   #5147     +/-   ##
=========================================
- Coverage     76.2%   76.2%   -0.0%     
=========================================
  Files          760     779     +19     
  Lines        61568   62651   +1083     
  Branches      8126    8245    +119     
=========================================
+ Hits         46898   47721    +823     
- Misses       14670   14930    +260     

Files with missing lines	Coverage Δ
include/xrpl/basics/MPTAmount.h	100.0% <100.0%> (ø)
include/xrpl/basics/Number.h	100.0% <100.0%> (ø)
include/xrpl/basics/base_uint.h	96.6% <ø> (ø)
include/xrpl/protocol/AmountConversions.h	87.5% <100.0%> (ø)
include/xrpl/protocol/Feature.h	100.0% <ø> (ø)
include/xrpl/protocol/Indexes.h	100.0% <100.0%> (ø)
include/xrpl/protocol/Issue.h	100.0% <100.0%> (ø)
include/xrpl/protocol/MPTIssue.h	100.0% <100.0%> (ø)
include/xrpl/protocol/SField.h	100.0% <ø> (ø)
include/xrpl/protocol/SOTemplate.h	96.3% <100.0%> (+1.3%)	⬆️
... and 72 more

... and 2 files with indirect coverage changes

[Bronek]

@donovanhide , I just realized that I pointed you to the wrong specification, sorry about that. This PR implements Single Asset Vault specification. It is in relation to Lending Protocol but a separate specification, because these two are related. Single Asset Vault is a prerequisite for lending protocol(s).

[donovanhide]

@Bronek It's ok, I followed the link in Lending XLS, but thanks anyway! 👍