Merged
Conversation
This change amendment-guards the preclaim for `TokenEscrow`, as well as expands tests to increase code coverage.
The CMake statements that make it seem as if the number of cores used to build external project dependencies is halved don't actually do anything. This change removes these statements.
Multi-line log messages are hard to work with. Writing these handful of related messages as one message should make the log a tiny bit easier to manage.
This change allows users to submit simulate requests from a multi-sign account without needing to specify the accounts that are doing the multi-signing, and fixes an error with simulate that allowed double-"signed" (both single-sign and multi-sign public keys are provided) transactions.
The tests that ensure `tfInnerBatchTxn` won't block delegated transactions silently fail in `Delegate_test.cpp`. This change removes these cases from that file and adds them to `Batch_test.cpp` instead where they do not silently fail, because there the batch delegate results are explicitly checked. Moving them to that file further avoids refactoring many helper functions.
bthomee
approved these changes
Jun 12, 2025
Collaborator
|
@legleux the libXRPL check fails as follows: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes
This document contains the notes for the release
2.5.0-rc2ofrippled, the reference server implementation of the XRP Ledger protocol. To learn more about how to build, run or update arippledserver, visit https://xrpl.org/install-rippled.htmlThis release adds new features and bug fixes.
2.5.0-rc2- 2025-06-11📝 Amendments
🦟📝 Fix Amendments
fixPayChanV1fixPayChanV1(fixPayChanCancelAfter #4717)fixAMMv1_3(Add fixAMMv1_3 amendment #5203)🚀 Features
🐛 Bug Fixes
LogicError, just dostd::abort#5338)channel_authorizewhensigning_supportis disabled (fix: disablechannel_authorizewhensigning_supportis disabled #5385)CODEOWNERS(chore: Update path in CODEOWNERS #5440)VaultDeposit(Fix handling of expired credentials inVaultDeposit#5452)TokenEscrowpreclaim and expand tests (fix: Amendment GuardTokenEscrowpreclaim #5473)simulate(fix: improve multisign usage ofsimulate#5479)🚜 Refactor
📚 Documentation
-j $(nproc)toBUILD.md(docs(BUILD): add -j $(nproc) #5288)🧪 Testing
⚙️ Miscellaneous Tasks