Lending: Refactor the bulk of testLifecycle into a function #5564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ximinez
force-pushed
the
ximinez/lending-XLS-66-test-wip
branch
8 times, most recently
from
214bac4 to
0949c7e
Compare
ximinez
force-pushed
the
ximinez/lending-XLS-66-test-wip
branch
6 times, most recently
from
c9f33aa to
0a78141
Compare
ximinez
force-pushed
the
ximinez/lending-XLS-66-test-wip
branch
2 times, most recently
from
2661c7f to
3489ed8
Compare
ximinez
force-pushed
the
ximinez/lending-XLS-66
branch
from
1bf68f7 to
1628756
Compare
ximinez
force-pushed
the
ximinez/lending-XLS-66-test-wip
branch
4 times, most recently
from
916df9a to
9df2030
Compare
ximinez
force-pushed
the
ximinez/lending-XLS-66-test-wip
branch
2 times, most recently
from
4e01651 to
c07aeaa
Compare
ximinez
force-pushed
the
ximinez/lending-XLS-66
branch
from
7f478d9 to
e62efa2
Compare
ximinez
force-pushed
the
ximinez/lending-XLS-66-test-wip
branch
6 times, most recently
from
6592850 to
ad0053f
Compare
ximinez
force-pushed
the
ximinez/lending-XLS-66
branch
from
156186d to
590f69c
Compare
ximinez
changed the base branch from
ximinez/lending-XLS-66
to
ximinez/lending-XLS-66-2
- Exclude LogicError lines in ApplyView.cpp (specifically directory operations) from code coverage. - Replace the ability to set the next page on a new directory page with an assert, because nothing uses it right now. - Early return with success for batch inner transactions in preflight2.
…iminez/lending-XLS-66-2 * XRPLF/ximinez/develop-nolending: Revert "Implement Lending Protocol (unsupported) (5270)" Implement Lending Protocol (unsupported) (5270)
ximinez
force-pushed
the
ximinez/lending-XLS-66-2
branch
from
335b9be to
c953073
Compare
ximinez
changed the base branch from
ximinez/lending-XLS-66-2
to
ximinez/lending-XLS-66-ongoing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)