Conversation
mvadari
added
CI
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5665 +/- ##
=========================================
- Coverage 78.8% 78.8% -0.0%
=========================================
Files 814 814
Lines 71305 71304 -1
Branches 8344 8349 +5
=========================================
- Hits 56196 56190 -6
- Misses 15109 15114 +5 see 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
.github/workflows/clang-format.yml
Outdated
| echo "${SUGGESTION}" | ||
| exit 1 | ||
|
|
||
| - name: Use Node.js ${{ env.NODE_VERSION }} |
There was a problem hiding this comment.
Can you add this as a separate job, instead of making it part of the clang-format job?
I also propose that we create a separate ghcr.io/xrplf/ci/tools-rippled-prettier Docker image for this job, so you don't have to do any setting up at all.
There was a problem hiding this comment.
Created a separate CI that just uses a Github runner (for now at least)
| BreakBeforeBraces: Custom | ||
| BraceWrapping: | ||
| AfterClass: true | ||
| AfterControlStatement: true | ||
| AfterEnum: false | ||
| AfterFunction: true | ||
| AfterNamespace: false | ||
| AfterObjCDeclaration: true | ||
| AfterStruct: true | ||
| AfterUnion: true | ||
| BeforeCatch: true | ||
| BeforeElse: true | ||
| IndentBraces: false |
There was a problem hiding this comment.
Do these changes affect prettier in any way?
There was a problem hiding this comment.
No, but they'll affect both JSON and C++ clang-format (I think - the clang-format docs aren't great at telling you which options affect which languages)
|
Should we add mention of this in CONTRIBUTING.md? |
|
Added in #5661 |
3 participants
High Level Overview of Change
This PR adds CI support for
prettierto run on Markdown/JS/JSON/YAML files, and also adds it to the pre-commit.Context of Change
Followup PR from #5657 (see #5657 (comment))
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
None