Skip to content

chore: Reverts formatting changes to external files, adds formatting changes to proto files#5711

Merged
bthomee merged 3 commits intodevelopfrom
bthomee/clang-format
Aug 21, 2025
Merged

chore: Reverts formatting changes to external files, adds formatting changes to proto files#5711
bthomee merged 3 commits intodevelopfrom
bthomee/clang-format

Conversation

@bthomee
Copy link
Collaborator

@bthomee bthomee commented Aug 21, 2025

High Level Overview of Change

This change reverts the formatting applied to external files and adds formatting of proto files.

As clang-format will complain if a proto file is modified or moved, since the .clang-format file does not explicitly contain a section for proto files, the change has been included in this PR as well.

Context of Change

In #5657 the external files were formatted, which should not have been done. Our codebase further contains proto files, which need to be formatted too.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

@codecov
Copy link

codecov bot commented Aug 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.7%. Comparing base (fb89213) to head (219f9f6).
⚠️ Report is 7 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5711     +/-   ##
=========================================
- Coverage     78.8%   78.7%   -0.1%     
=========================================
  Files          814     814             
  Lines        71305   71640    +335     
  Branches      8351    8442     +91     
=========================================
+ Hits         56196   56361    +165     
- Misses       15109   15279    +170     

see 201 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@Bronek Bronek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

@Bronek Bronek added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Aug 21, 2025
@bthomee bthomee merged commit b13370a into develop Aug 21, 2025
63 of 68 checks passed
@bthomee bthomee deleted the bthomee/clang-format branch August 21, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants