chore: Reverts formatting changes to external files, adds formatting changes to proto files#5711
Merged
chore: Reverts formatting changes to external files, adds formatting changes to proto files#5711
Conversation
9 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5711 +/- ##
=========================================
- Coverage 78.8% 78.7% -0.1%
=========================================
Files 814 814
Lines 71305 71640 +335
Branches 8351 8442 +91
=========================================
+ Hits 56196 56361 +165
- Misses 15109 15279 +170 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This change reverts the formatting applied to external files and adds formatting of proto files.
As clang-format will complain if a proto file is modified or moved, since the
.clang-formatfile does not explicitly contain a section for proto files, the change has been included in this PR as well.Context of Change
In #5657 the external files were formatted, which should not have been done. Our codebase further contains proto files, which need to be formatted too.
Type of Change
.gitignore, formatting, dropping support for older tooling)