Skip to content

Merge 2.6.0-rc3 into develop#5724

Merged
ximinez merged 3 commits intodevelopfrom
ximinez/merge-release
Aug 23, 2025
Merged

Merge 2.6.0-rc3 into develop#5724
ximinez merged 3 commits intodevelopfrom
ximinez/merge-release

Conversation

@ximinez
Copy link
Collaborator

@ximinez ximinez commented Aug 22, 2025

This PR must be merged manually using a push. Do not use the Github UI.

See #5723.

@ximinez ximinez marked this pull request as ready for review August 22, 2025 22:21
@ximinez ximinez requested review from a team, bthomee and vlntb August 22, 2025 22:21
@ximinez ximinez marked this pull request as draft August 22, 2025 23:22
@ximinez ximinez marked this pull request as ready for review August 22, 2025 23:22
@ximinez ximinez closed this Aug 22, 2025
@ximinez ximinez reopened this Aug 22, 2025
@ximinez ximinez added DraftRunCI Normally CI does not run on draft PRs. This opts in. and removed DraftRunCI Normally CI does not run on draft PRs. This opts in. labels Aug 22, 2025
@ximinez ximinez force-pushed the ximinez/merge-release branch from 4652116 to 7775c72 Compare August 22, 2025 23:56
@codecov
Copy link

codecov bot commented Aug 23, 2025

Codecov Report

❌ Patch coverage is 78.68852% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.7%. Comparing base (fb89213) to head (7775c72).
⚠️ Report is 16 commits behind head on develop.

Files with missing lines Patch % Lines
include/xrpl/basics/TaggedCache.ipp 80.4% 10 Missing ⚠️
src/xrpld/app/ledger/LedgerHistory.cpp 66.7% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5724     +/-   ##
=========================================
- Coverage     78.8%   78.7%   -0.1%     
=========================================
  Files          814     814             
  Lines        71305   71680    +375     
  Branches      8351    8445     +94     
=========================================
+ Hits         56196   56396    +200     
- Misses       15109   15284    +175     
Files with missing lines Coverage Δ
include/xrpl/basics/SHAMapHash.h 93.5% <ø> (ø)
include/xrpl/basics/TaggedCache.h 100.0% <ø> (ø)
include/xrpl/basics/partitioned_unordered_map.h 99.2% <ø> (+0.3%) ⬆️
src/libxrpl/protocol/BuildInfo.cpp 98.2% <ø> (ø)
src/xrpld/rpc/handlers/GetCounts.cpp 96.8% <100.0%> (ø)
src/xrpld/app/ledger/LedgerHistory.cpp 52.7% <66.7%> (+1.9%) ⬆️
include/xrpl/basics/TaggedCache.ipp 85.8% <80.4%> (-0.4%) ⬇️

... and 195 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ximinez ximinez merged commit 7775c72 into develop Aug 23, 2025
26 checks passed
@ximinez ximinez deleted the ximinez/merge-release branch August 23, 2025 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants