Merged
Conversation
mvadari
added
the
Trivial
mvadari
changed the title
TxMeta
mvadari
changed the title
TxMetaTxMeta constructors
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5845 +/- ##
=========================================
- Coverage 78.3% 78.3% -0.0%
=========================================
Files 817 817
Lines 69003 68989 -14
Branches 8318 8318
=========================================
- Hits 54028 54016 -12
+ Misses 14975 14973 -2
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
mvadari
changed the title
TxMeta constructorsTxMeta
mvadari
removed
the
Trivial
vvysokikh1
approved these changes
Oct 28, 2025
Collaborator
vvysokikh1
left a comment
vvysokikh1
left a comment
There was a problem hiding this comment.
lgtm! small nit can be ignored
oleks-rip
reviewed
Oct 30, 2025
oleks-rip
reviewed
Oct 31, 2025
src/libxrpl/protocol/TxMeta.cpp
Outdated
| if (index != -1) | ||
| { | ||
| auto inner = dynamic_cast<STObject const*>(&it.peekAtIndex(index)); | ||
| auto inner = |
oleks-rip
approved these changes
Oct 31, 2025
mvadari
added
the
Ready to merge
bthomee
approved these changes
Oct 31, 2025
bthomee
approved these changes
Oct 31, 2025
Bronek
pushed a commit
that referenced
this pull request
Nov 3, 2025
This change: * Simplifies the `TxMeta` constructors - both were setting the same set of fields, and to make it harder for future bugs to arise and keep the code DRY, we can combine those into one helper function. * Removes an unused constructor. * Renames the variables to avoid Hungarian naming. * Removes a bunch of now-unnecessary helper functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR:
TxMetaconstructors - both were setting the same set of fields, and to make it harder for future bugs to arise and keep the code DRY, we can combine those into one helper function.Context of Change
DRY, pulled out of #5600
Type of Change
API Impact
N/A
Test Plan
CI passes.