XLS-68: Sponsor by tequdev · Pull Request #5887 · XRPLF/rippled

tequdev · 2025-10-14T03:40:19Z

High Level Overview of Change

Context of Change

Type of Change

New feature (non-breaking change which adds functionality)

API Impact

Public API: New feature (new methods and/or new fields)
Public API: Breaking change (in general, breaking changes should only impact the next api_version)
libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
Peer protocol change (must be backward compatible or bump the peer protocol version)

- not fully tested - need to modify: Reserve check where using sfOwnerCount

…d Account

yinyiqian1 · 2026-01-30T17:40:27Z

src/test/app/Invariants_test.cpp

                {
                    // uncomment if you want to log the invariant failure
-                    // std::cerr << "   --> " << m << std::endl;
+                    // std::cerr << " expected --> " << m << std::endl;


The std::cerr lines should be deleted, as well as line 98

I think these lines are well worth keeping for debugging purposes.

OK. I see. Just verified that the existing rippled/develop is already having the std::cerr.
So maybe we don't need to make any change here.

yinyiqian1 · 2026-01-30T20:24:14Z

src/xrpld/app/tx/detail/SponsorshipSet.cpp

+        if (account != sponsor)
+            return temMALFORMED;
+
+        if ((flags & tfSponsorshipSetRequireSignForFee) && (flags & tfSponsorshipClearRequireSignForFee))


I was suggesting in my previous comment (#5887 (comment)) that we should move the flag check for deleting object into our main if (flags & tfDeleteObject) section.

////// this was in your previous version in the beginning of preflight. if (flags & tfDeleteObject) { // check Flags if (flags & (tfSponsorshipSetRequireSignForFee | tfSponsorshipSetRequireSignForReserve | tfSponsorshipClearRequireSignForFee | tfSponsorshipClearRequireSignForReserve)) return temINVALID_FLAG; }

The else section should not be touched.

fixed

fe07547

This did not address the comment either.

You have a global check for the flags, but you checked them again in the else section.

We should not use two if (flags & tfDeleteObject)... else ... in preflight. Please combine in one if else.

The code will be like:

NotTEC SponsorshipSet::preflight(PreflightContext const& ctx) { auto const flags = ctx.tx.getFlags(); if ((flags & tfSponsorshipSetRequireSignForFee) && (flags & tfSponsorshipClearRequireSignForFee)) return temINVALID_FLAG; if ((flags & tfSponsorshipSetRequireSignForReserve) && (flags & tfSponsorshipClearRequireSignForReserve)) return temINVALID_FLAG; //..... if (flags & tfDeleteObject) { // can not combine with any modification flags when deleting constexpr std::uint32_t modifyFlags = tfSponsorshipSetRequireSignForFee | tfSponsorshipSetRequireSignForReserve | tfSponsorshipClearRequireSignForFee | tfSponsorshipClearRequireSignForReserve; if (flags & modifyFlags) return temINVALID_FLAG; // can not include these fields when deleting if (ctx.tx.isFieldPresent(sfFeeAmount) || ctx.tx.isFieldPresent(sfReserveCount) || ctx.tx.isFieldPresent(sfMaxFee)) return temMALFORMED; } else { // ... } return tesSUCCESS; }

Sorry about that. Now I understand what you were pointing out.

oleks-rip · 2026-02-13T18:19:05Z

include/xrpl/protocol/detail/sfields.macro

+TYPED_SFIELD(sfSponsor,                  ACCOUNT,   27)
+TYPED_SFIELD(sfHighSponsor,              ACCOUNT,   28)
+TYPED_SFIELD(sfLowSponsor,               ACCOUNT,   29)
+TYPED_SFIELD(sfCounterpartySponsor,      ACCOUNT,   30)


XLS-68 updated, sfCounterpartySponsor not present

@mvadari
I believe this field is necessary, but was it missing from the spec?

include/xrpl/protocol/detail/transactions.macro

oleks-rip · 2026-02-13T18:27:59Z

include/xrpl/protocol/detail/transactions.macro

+    featureSponsor,
+    noPriv,
+    ({
+    {sfCounterpartySponsor, soeOPTIONAL},


XLS-68 updated, please fix (sfSponsor)

#5887 (comment)

oleks-rip · 2026-02-20T16:16:19Z

include/xrpl/protocol/detail/transactions.macro

+    featureSponsor,
+    noPriv,
+    ({
+    {sfCounterpartySponsor, soeOPTIONAL},


XLS updated, sfSponsor

#5887 (comment)

mvadari and others added 30 commits June 17, 2025 11:32

PoC for sponsored fees

cad305a

PoC for sponsored reserve

43c16f3

Merge remote-tracking branch 'upstream/develop' into sponsor

5b9c767

SponsorReserve,SponsorAccount

d40f8cc

- not fully tested - need to modify: Reserve check where using sfOwnerCount

fix OwnerCount

198ed72

test Disabled

a798c60

fix addEmptyHolding

f0addd8

check reserve

67bdd09

clang-format

0bddc95

fix fees().accountReserve(0) to fees().reserve

6e01f23

Add SponsorTransfer

abd8620

add reserve checks for SponsorTransfer

5e65813

use helper

2071b39

Merge remote-tracking branch 'upstream/develop' into sponsor

9ff71aa

Sponsor signing

02d8f9f

v2. SponsorSet

e589b71

fullly rename

8e895a3

Create Sponsored Account / AccountDelete with ltSponsorship, Sponsore…

4eea76c

…d Account

sfAccount to sfOwner

6aa0331

MaxFee

4abd94e

feePayer

1cdf7bb

add MaxFee test

110b222

test AccountDelete for sponsorship

20bce64

test checks

6c0732c

fix test error

2a27280

test SponsorshipRequire flags

5ac7bbf

Sponsor permissions

759f843

High/Low SponsorAccount

2afe570

add InvariantCheck for sponsor count

a43ae9a

add tests

89af817

tequdev added 3 commits January 30, 2026 23:29

Merge remote-tracking branch 'upstream/develop' into sponsor

8d24afe

add test for Sponsored trustline

4e87de7

clang-format

d390bc7

yinyiqian1 reviewed Jan 30, 2026

View reviewed changes

tequdev added 5 commits February 1, 2026 20:38

Add tests for LoanBroker transactions

f820908

Add tests for Loan

37f4ea9

sfSponsorAccount -> sfSponsor/sfCounterpartySponsor

49c5269

address review

fe07547

address review

e1aee43

achowdhry-ripple mentioned this pull request Feb 11, 2026

XLS-0068: Sponsored Fees and Reserves XRPLF/xrpl.js#3199

Open

9 tasks

tequdev added 13 commits February 18, 2026 13:39

Merge remote-tracking branch 'upstream/develop' into sponsor

446681d

audit 3

392a913

audit 4

d1d613d

audit 5

c1e1be5

audit 6

686f945

audit 7

bf4fa37

audit 8

f6d79f7

audit 9

9859ba8

audit 10

9cde57d

audit 11

fe5fab0

audit 12

2fd8e1b

audit 13

dcfcb1f

audit 14

293394f

oleks-rip reviewed Feb 20, 2026

View reviewed changes

tequdev added 6 commits February 22, 2026 00:01

Allow zero value for ReserveCount, FeeAmount, MaxFee

178bb8f

Add SponsorshipEnd/Create/Reassign flags for SponsorshipTransfer

f86b255

Add sfSponsee to ttSponsorshipTransfer

4a91351

Add tests for deleting Sponsor Account with ltSponsorship

1ad6dd1

Merge remote-tracking branch 'upstream/develop' into sponsor

062ece3

clang-format

9961887

Conversation

tequdev commented Oct 14, 2025

High Level Overview of Change

Context of Change

Type of Change

API Impact

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yinyiqian1 Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yinyiqian1 Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yinyiqian1 Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

yinyiqian1 Feb 3, 2026 •

edited

Loading

yinyiqian1 Jan 30, 2026 •

edited

Loading

yinyiqian1 Feb 2, 2026 •

edited

Loading