experimental: WASM trace logs stored in a db and outputted in tx#5980
Draft
mvadari wants to merge 19 commits intoXRPLF:ripple/smart-escrowfrom
Draft
experimental: WASM trace logs stored in a db and outputted in tx#5980mvadari wants to merge 19 commits intoXRPLF:ripple/smart-escrowfrom
tx#5980mvadari wants to merge 19 commits intoXRPLF:ripple/smart-escrowfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## ripple/smart-escrow #5980 +/- ##
=====================================================
- Coverage 79.8% 79.8% -0.0%
=====================================================
Files 846 847 +1
Lines 73679 73753 +74
Branches 8304 8334 +30
=====================================================
+ Hits 58804 58839 +35
- Misses 14875 14914 +39
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR takes all the trace logs that are printed via host functions (so are dev-generated) and stores them in a separate database, which allows them to be printed as a part of
tx.Todo list for this PR:
Context of Change
Easier debugging
Type of Change
API Impact
Adds a
wasm_debug_logsfield to thetxoutput for any transaction that executes WASM (currently justEscrowFinish).Test Plan
TODO