DRAFT: Fill in payment computation shortages #6004
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ximinez
force-pushed
the
ximinez/lending-shortages
branch
5 times, most recently
from
b9fc042 to
206b543
Compare
This reverts commit 165478b.
ximinez
force-pushed
the
ximinez/lending-shortages
branch
from
206b543 to
0008e2d
Compare
ximinez
force-pushed
the
ximinez/lending-XLS-66
branch
from
156186d to
590f69c
Compare
…nez/lending-shortages * XRPLF/ximinez/lending-XLS-66: (48 commits) Fix formatting Review feedback from @gregtatcam: typo Review feedback from @Tapanito, @gregtatcam, and @shawnxie999 Update src/xrpld/app/tx/detail/LoanBrokerCoverClawback.cpp Fix formatting Add deep freeze check to LoanBrokerDelete (6053) Fix build error with LoanBroker invariant Address a couple of feedback items from @Tapanito and @shawnxie999: Review feedback from @shawnxie999: removeEmptyHolding Review feedback from @shawnxie999: broker owner count Update src/xrpld/app/tx/detail/LoanBrokerCoverClawback.cpp Update src/xrpld/app/tx/detail/LoanBrokerCoverDeposit.cpp Update src/xrpld/app/tx/detail/LoanBrokerSet.cpp Add a LoanBroker invariant to compare CoverAvailable to balance refactor: Retire RequireFullyCanonicalSig amendment (6035) refactor: Retire DeletableAccounts amendment (6056) refactor: Retire CryptoConditionsSuite amendment (6036) Review feedback from @gregtatcam: variable name Review feedback from @gregtatcam: readability From discussion with @gregtatcam: Revert "Payment" ...
…nez/lending-shortages * XRPLF/ximinez/lending-XLS-66: ci: Trigger clio pipeline on PRs targeting release branches (6080) Review feedback from @shawnxie999: MPT Clawback Move the ValidPseudoAccounts class back to its original location Fix formatting again refactor: Retire Flow and FlowSortStrands amendments (6054) Add additional documentation to Lending Protocol (6037)
ximinez
changed the base branch from
ximinez/lending-XLS-66
to
ximinez/lending-XLS-66-2
- Exclude LogicError lines in ApplyView.cpp (specifically directory operations) from code coverage. - Replace the ability to set the next page on a new directory page with an assert, because nothing uses it right now. - Early return with success for batch inner transactions in preflight2.
…iminez/lending-XLS-66-2 * XRPLF/ximinez/develop-nolending: Revert "Implement Lending Protocol (unsupported) (5270)" Implement Lending Protocol (unsupported) (5270)
ximinez
force-pushed
the
ximinez/lending-XLS-66-2
branch
from
335b9be to
c953073
Compare
ximinez
changed the base branch from
ximinez/lending-XLS-66-2
to
ximinez/lending-XLS-66-ongoing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a placeholder to keep this code around.
High Level Overview of Change
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)