fix: correct index for limit in book_offers CLI#6043
Merged
Conversation
book_offers CLI
vvysokikh1
approved these changes
Nov 17, 2025
Tapanito
approved these changes
Nov 17, 2025
Tapanito
reviewed
Nov 17, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6043 +/- ##
=======================================
Coverage 78.6% 78.6%
=======================================
Files 818 818
Lines 68983 68989 +6
Branches 8246 8241 -5
=======================================
+ Hits 54196 54210 +14
+ Misses 14787 14779 -8
🚀 New features to boost your workflow:
|
vvysokikh1
approved these changes
Nov 17, 2025
2 tasks
Collaborator
Author
|
#6044 is a version of this PR that covers more cases and is broader. We may want to merge this first or go straight to that one, unsure. |
Collaborator
|
@Tapanito are there any additional things that need to be addressed, or is this good to go? |
Tapanito
approved these changes
Nov 20, 2025
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR fixes an indexing typo in the
book_offersCLI processing. This does not affect the HTTPS/WS RPC processing.It's a fairly straightforward fix - there is a length check on whether the list length is
>= 5, but the5uindex is taken instead of the4uindex (as the last in the list).Context of Change
Reported as a part of the Lending Protocol Attackathon
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
There is a minor fix in the
book_offersCLI. This does not affect the HTTPS/WS RPC processing.Test Plan
CI passes.