fix casting issues in RPC CLIs, remove proof from book_offers
#6044
+257
−452
Codecov / codecov/project
succeeded
Mar 3, 2026 in 0s
79.8% (target 75.0%)
View this Pull Request on Codecov
79.8% (target 75.0%)
Details
Codecov Report
❌ Patch coverage is 86.79245% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.8%. Comparing base (afc660a) to head (c7b39df).
| Files with missing lines | Patch % | Lines |
|---|---|---|
| src/xrpld/rpc/detail/RPCCall.cpp | 86.8% | 7 Missing |
Additional details and impacted files
@@ Coverage Diff @@
## develop #6044 +/- ##
=======================================
Coverage 79.8% 79.8%
=======================================
Files 858 858
Lines 67757 67785 +28
Branches 7557 7554 -3
=======================================
+ Hits 54064 54095 +31
+ Misses 13693 13690 -3 | Files with missing lines | Coverage Δ | |
|---|---|---|
| include/xrpl/server/NetworkOPs.h | 100.0% <ø> (ø) |
|
| src/xrpld/app/misc/NetworkOPs.cpp | 70.1% <ø> (ø) |
|
| src/xrpld/rpc/handlers/BookOffers.cpp | 98.9% <ø> (-<0.1%) |
⬇️ |
| src/xrpld/rpc/handlers/Subscribe.cpp | 91.0% <ø> (ø) |
|
| src/xrpld/rpc/detail/RPCCall.cpp | 93.5% <86.8%> (-0.2%) |
⬇️ |
... and 5 files with indirect coverage changes
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Loading