Conversation
Avoids an assertion failure in NetworkOPsImp::apply in the unlikely event that all incoming transactions are invalid.
This change introduces the `fixDirectoryLimit` amendment to remove the directory pages limit. We found that the directory size limit is easier to hit than originally assumed, and there is no good reason to keep this limit, since the object reserve provides the necessary incentive to avoid creating unnecessary objects on the ledger.
vvysokikh1
force-pushed
the
vvysokikh1/release-2.6.2-rc1
branch
from
28bb5c8 to
9d6f821
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release #6057 +/- ##
=========================================
- Coverage 78.8% 77.8% -1.0%
=========================================
Files 814 814
Lines 71309 68151 -3158
Branches 8346 8349 +3
=========================================
- Hits 56198 53034 -3164
- Misses 15111 15116 +5
- Partials 0 1 +1
... and 500 files with indirect coverage changes 🚀 New features to boost your workflow:
|
ximinez
approved these changes
Nov 19, 2025
vvysokikh1
force-pushed
the
vvysokikh1/release-2.6.2-rc1
branch
3 times, most recently
from
e945532 to
73d7384
Compare
bthomee
approved these changes
Nov 19, 2025
vvysokikh1
force-pushed
the
vvysokikh1/release-2.6.2-rc1
branch
from
73d7384 to
df24ee0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)