fix: Inner batch transactions never have valid signatures #6069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduces amendment `fixBatchInnerSigs`
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6069 +/- ##
=========================================
- Coverage 78.6% 78.6% -0.0%
=========================================
Files 818 818
Lines 68938 68944 +6
Branches 8240 8236 -4
=========================================
- Hits 54177 54172 -5
- Misses 14761 14772 +11
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
7 tasks
ximinez
changed the title
dangell7
requested changes
Dec 2, 2025
| auto const pkSigner = sigObject.getFieldVL(sfSigningPubKey); | ||
| // Ignore signature check on batch inner transactions | ||
| if (sigObject.isFlag(tfInnerBatchTxn) && view.rules().enabled(featureBatch)) | ||
| bool const useCtx = view.rules().enabled(fixBatchInnerSigs); |
Collaborator
There was a problem hiding this comment.
This doesnt seem right. Can't you just check for the parentBatchId?
| // original `Batch` implementation. An inner transaction never | ||
| // has a valid signature. | ||
| bool const neverValid = rules.enabled(fixBatchInnerSigs); | ||
| if (!neverValid) |
…nersigs * XRPLF/develop: Implement Lending Protocol (unsupported) (5270)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Introduces a fix amendment that will skip over a problematic and unnecessary block in
checkValiditythat will set flags indicating that an inner transaction has a valid signature. Inner transactions, by definition, never have valid signatures.I don't think this is exploitable as such, because there are additional checks before an inner transaction is applied to the ledger, but why take that chance?
It updates some of the callers of
checkValidityto skip over the function if thetfInnerBatchTxnflag is set, either by treating it as always valid, or always invalid, depending on the context. The remaining will always fail for an inner tx.Introduces amendment
fixBatchInnerSigs.Context of Change
This discussion on the Lending Protocol implementation PR: #5270 (comment)
Type of Change