Charge higher fees for and reject heavy TMGetObjectByHashLimit queries #6110
+72
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…heavy-TMGetObjectByHash-queries
pratikmankawde
changed the title
pratikmankawde
commented
Dec 8, 2025
| return; | ||
| } | ||
|
|
||
| // Charge heavier fee for large requests (>256 objects) |
Collaborator
Author
There was a problem hiding this comment.
Why 256? What should be these incremental boundaries?
pratikmankawde
commented
Dec 8, 2025
| } | ||
| else | ||
| { | ||
| fee_.update( |
Collaborator
Author
There was a problem hiding this comment.
Should the minimum fee be feeModerateBurdenPeer or feeTrivialPeer?
pratikmankawde
commented
Dec 8, 2025
src/xrpld/overlay/detail/PeerImp.cpp
Outdated
| // (only when fix is enabled) | ||
| if (replyBudgetBytes > 0 && | ||
| replyBytes + dataSz + 64 > replyBudgetBytes) | ||
| break; |
Collaborator
Author
There was a problem hiding this comment.
Do we break here, meaning we send whatever we accumulated or just not send anything?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context of Change
Complete details of the context of the change and the change itself is shared in the ticket associated with this.
I am not duplicating the details here to avoid redundancy and confusion.
I will add details of the test and impact in the ticket itself.
Type of Change
.gitignore, formatting, dropping support for older tooling)