Frozen IOUs should still be transferable to the issuer #6113
+121
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
VaultWithdraw was incorrectly rejecting withdrawals of frozen IOU assets in all cases, including withdrawals back to the asset issuer. This behavior violated the XRP Ledger protocol, which allows frozen IOU
assets to be returned to their issuer.
Context of Change
Two issues were fixed:
checkFrozen()calls inpreclaim()were always executed, even when the destination or submitter was the asset issueraccountHolds()call indoApply()was hardcoded to useFreezeHandling::fhZERO_IF_FROZEN, treating frozen shares as zero balance even for issuer-involved transactionsType of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)