Skip to content

Conversation

@Tapanito
Copy link
Collaborator

@Tapanito Tapanito commented Dec 5, 2025

Fixes overpayment calcuation, adds tests ad refactors to be without side effects.

@Tapanito Tapanito requested a review from ximinez December 5, 2025 12:34
@Tapanito Tapanito requested a review from a team as a code owner December 5, 2025 12:34
@Tapanito Tapanito force-pushed the tapanito/lending-overpayment-value-change branch from cb69f06 to cf33c9d Compare December 8, 2025 10:30
@Tapanito Tapanito changed the title draft: Lending protocol overpayment Lending Protocol: Fix Overpayment ValueChange calculation Dec 8, 2025
@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

❌ Patch coverage is 93.65079% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.1%. Comparing base (5224636) to head (f9438cc).

Files with missing lines Patch % Lines
src/xrpld/app/misc/detail/LendingHelpers.cpp 96.4% 2 Missing ⚠️
src/xrpld/app/tx/detail/LoanSet.cpp 71.4% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                       Coverage Diff                        @@
##           ximinez/lending-XLS-66-ongoing   #6114     +/-   ##
================================================================
- Coverage                            79.1%   79.1%   -0.0%     
================================================================
  Files                                 839     839             
  Lines                               71370   71367      -3     
  Branches                             8322    8324      +2     
================================================================
- Hits                                56453   56447      -6     
- Misses                              14917   14920      +3     
Files with missing lines Coverage Δ
src/xrpld/app/misc/LendingHelpers.h 95.0% <ø> (ø)
src/xrpld/app/misc/detail/LendingHelpers.cpp 90.0% <96.4%> (-0.3%) ⬇️
src/xrpld/app/tx/detail/LoanSet.cpp 91.4% <71.4%> (+<0.1%) ⬆️

... and 1 file with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants