Skip to content

clean up host function header files with macros#6218

Draft
mvadari wants to merge 25 commits intoXRPLF:ripple/wasmi-host-functionsfrom
mvadari:hf-macro2
Draft

clean up host function header files with macros#6218
mvadari wants to merge 25 commits intoXRPLF:ripple/wasmi-host-functionsfrom
mvadari:hf-macro2

Conversation

@mvadari
Copy link
Collaborator

@mvadari mvadari commented Jan 14, 2026

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@mvadari mvadari added the DraftRunCI Normally CI does not run on draft PRs. This opts in. label Jan 14, 2026
@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.5%. Comparing base (1b4a564) to head (8716854).

Files with missing lines Patch % Lines
...xrpld/app/wasm/detail/HostFuncImplLedgerHeader.cpp 85.7% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                     Coverage Diff                     @@
##           ripple/wasmi-host-functions   #6218   +/-   ##
===========================================================
  Coverage                         80.5%   80.5%           
===========================================================
  Files                              861     861           
  Lines                            67751   67749    -2     
  Branches                          7285    7282    -3     
===========================================================
+ Hits                             54544   54547    +3     
+ Misses                           13207   13202    -5     
Files with missing lines Coverage Δ
src/xrpld/app/wasm/HostFunc.h 100.0% <ø> (ø)
src/xrpld/app/wasm/HostFuncImpl.h 83.3% <ø> (ø)
src/xrpld/app/wasm/detail/HostFuncImplFloat.cpp 98.2% <100.0%> (ø)
src/xrpld/app/wasm/detail/HostFuncWrapper.cpp 98.1% <100.0%> (-<0.1%) ⬇️
...xrpld/app/wasm/detail/HostFuncImplLedgerHeader.cpp 94.4% <85.7%> (-5.6%) ⬇️

... and 2 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DraftRunCI Normally CI does not run on draft PRs. This opts in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant