Skip to content

chore: Remove unnecessary boost::system requirement from conanfile#6290

Merged
bthomee merged 1 commit intoXRPLF:developfrom
mathbunnyru:no_boost_system
Jan 28, 2026
Merged

chore: Remove unnecessary boost::system requirement from conanfile#6290
bthomee merged 1 commit intoXRPLF:developfrom
mathbunnyru:no_boost_system

Conversation

@mathbunnyru
Copy link
Collaborator

@mathbunnyru mathbunnyru commented Jan 28, 2026

High Level Overview of Change

Same as XRPLF/conan-center-index#34

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@mathbunnyru mathbunnyru added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Jan 28, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes an explicit Conan component dependency on boost::system from the package metadata, relying on transitive Boost component requirements instead.

Changes:

  • Drops boost::system from libxrpl’s cpp_info.components["libxrpl"].requires list.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mathbunnyru mathbunnyru added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Jan 28, 2026
@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.9%. Comparing base (5f638f5) to head (4848d31).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #6290     +/-   ##
=========================================
- Coverage     79.9%   79.9%   -0.0%     
=========================================
  Files          839     839             
  Lines        65528   65528             
  Branches      7271    7272      +1     
=========================================
- Hits         52328   52326      -2     
- Misses       13200   13202      +2     

see 3 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bthomee bthomee merged commit f3627fb into XRPLF:develop Jan 28, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants